fix(temp, iOS): Fix missing weak linking for Xcode 15 #1896
Conversation
|
@kkafar @WoLewicki Can you ensure that our example app is being correctly installed and launched on iOS 14 / iOS 16 if you're still using Xcode 14? 🙏 |
There was a problem hiding this comment.
I'm using latest XCode already.
We can have it merged in case you're working on iOS right now. If it is not the case we can wait a day or two for React Native release, then just bump RN versions in package.json.
One nitpick:
- We could also add
-Wloption as recommended in official workaround by apple. There is no harm in seeing linker warnings. Up to you.
|
Hey @tboba, 0.72.5 was released. I believe we can close this PR & open new one - with bumped version of RN. |
|
Hey @kkafar, let's leave this PR open for now - I'm testing RN on the newest version and unfortunately I'm still coming across the |
|
KK, I'll try it out soon |
|
As I'm looking on building Example apps on iOS 15 it seems to be fine, also the app is being launched correctly so I assume this PR is no longer relevant. |
Description
Currently it's not possible to build our example apps because of the recent changes in the newest Xcode 15.
In the changelog they're mentioning a new linter, which lacks the support of weak linking.
This PR introduces changes in Podfiles that are required to launch our example apps. They are mainly adding required flag (
-ld_classic) that is restoring the support for the classic linter.This change is temporary! We should observe and wait for the 0.72.5 patch in React Native that adds the support for classic linter inside their Podfiles.
You can check for more information about the newest changes in linter here.
Helpful links
Checklist